This repository was archived by the owner on Sep 16, 2025. It is now read-only.
Fixed an issue with data format provided by new cds api, added test#79
Open
y-pohlmann-lintas wants to merge 3 commits intooemof:devfrom
Open
Fixed an issue with data format provided by new cds api, added test#79y-pohlmann-lintas wants to merge 3 commits intooemof:devfrom
y-pohlmann-lintas wants to merge 3 commits intooemof:devfrom
Conversation
Member
|
The test pipeline is outdated. (Our fault.) Would you please merge dev? That should allow to run them, again. |
valid_time
p-snft
reviewed
Jun 26, 2025
Comment on lines
+382
to
+384
| #if 'valid_time' in ds: | ||
| # ds = ds.rename({'valid_time': 'time'}) | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| #if 'valid_time' in ds: | |
| # ds = ds.rename({'valid_time': 'time'}) |
Commented out code should be removed.
Member
|
One question: Is the change effecting only new data or is the name "time" changed to "valid_time" also if you download old datasets? If the latter is the case, I'd recommend to also change to "valid_time" here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API of the copernicus Climate Data Store (CDS) was revised at the end of September.
The data format provided by the API for ERA5 data has also changed.
The column containing the time stamps is now no longer called “time” but “valid_time”.
This leads to errors when reformatting the data provided into the dataframe format.
As a solution, I suggest simply renaming the column to “time” when reformatting.
I have also added a test that checks the reformatting into the Pandas dataframe format.
Sample data is used for this.